feat: add support for TypeScript based configs #632
Conversation
|
|
| return { | ||
| parser: 'sugarss', | ||
| syntax: 'sugarss', | ||
| // FIXME: To confirm. Apparently there's no longer an available option `mode`? |
There was a problem hiding this comment.
I need help with this one.
I am not sure whether this should be ignored or removed. This config key doesn't exist anymore.
| return { | ||
| parser: 'sugarss', | ||
| syntax: 'sugarss', | ||
| // FIXME: To confirm. Apparently there's no longer an available option `mode`? |
There was a problem hiding this comment.
There was a problem hiding this comment.
Is it not avaliable only in types?
There was a problem hiding this comment.
Is it not avaliable only in types?
I am not sure. According to the documentation: https://github.com/postcss/postcss-load-config#options
I don't see the mode option.
I tried searching in their codebase for options, but I can't find a mention of mode either. 🤔
There was a problem hiding this comment.
We apply mode to our logic so developer can use the mode option from configuration
There was a problem hiding this comment.
I want to clarify, this one comes from the webpack configuration - mode?
I guess, in this case, if I am not wrong, I could just merge the types from the PostCSS Config and the webpack config.
There was a problem hiding this comment.
|
I had to install two packages:
I have added test cases for two config types:
Lemme know if it's enough. I have skipped the other possible patterns, e.g. |
| import type { Config as PostCSSConfig } from 'postcss-load-config'; | ||
| import { Configuration as WebpackConfig } from 'webpack'; | ||
|
|
||
| module.exports = function (api: WebpackConfig): PostCSSConfig { |
There was a problem hiding this comment.
@alexander-akait I believe this is the way to solve the issue.
|
|
||
| module.exports = function (api: Config) { | ||
| module.exports = function (api: WebpackConfig): PostCSSConfig { |
There was a problem hiding this comment.
Nope, it should be https://github.com/webpack-contrib/postcss-loader/blob/master/src/utils.js#L152, it is mix of types, so I think we just need to add this to documents
There was a problem hiding this comment.
Feel free to update types in docs and we can merge + small example, thank you
Add a file for the future reference - `./src/config.d.ts`.
Replaced the old one with a new one, and added a file reference.
There was a problem hiding this comment.
@alexander-akait I allowed myself to add a new file for the future reference.
I couldn't import type in the test files since this repo doesn't use typescript; hence I have no idea how to load them. So, I've copied the content of this file.
There was a problem hiding this comment.
Is this what you were hoping to see by updating the docs? @alexander-akait
|
Oh, there is a bug in npm, I will merge and will fix it in the other PR, thank you for the PR |
Resolves #631
This PR contains a:
Motivation / Use-Case
TailwindCSS since version
^3.3.0has support for TypeScript based configs. Including PostCSS.Hence, I've added patterns to search for config files, which end with the following extensions:
ctsmtstsBreaking Changes
None so far.
Additional Info
#631