Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You may not @extend an outer selector from within @media. #72

Closed
jongbeau opened this issue Mar 30, 2015 · 8 comments
Closed

You may not @extend an outer selector from within @media. #72

jongbeau opened this issue Mar 30, 2015 · 8 comments

Comments

@jongbeau
Copy link

Hello,
I'm trying to build bootstrap-sass with sass-loader, and i'm getting the following error:

ERROR in ./~/css-loader!./~/sass-loader?outputStyle=expanded&includePaths[]=/Users/....../node_modules!./app/stylesheets/main.scss
Module build failed:
    .input-group-sm & {
                                     ^
      You may not @extend an outer selector from within @media.
You may only @extend selectors within the same directive.
From "@extend .input-sm" on line 48 of node_modules/bootstrap-sass/assets/stylesheets/bootstrap/_input-groups.scss

      in /Users/jason/dev/goco-client/node_modules/bootstrap-sass/assets/stylesheets/bootstrap/_forms.scss (line 189, column 39)
 @ ./app/stylesheets/main.scss 4:14-284

My relevant npm versions:

sass-loader@1.0.0
bootstrap-sass@3.3.4
node-sass@3.0.0-beta.4

Is this a known issue?

@joostfarla
Copy link

This is caused by a bug in libsass which has been solved in the latest 3.2 beta versions. Sass-loader v1.0.0 is bound to node-sass version 3.0.0-alpha, which provides the older libsass version containing this bug. See sass/libsass#943 for details.

@jtangelder, could you upgrade the node-sass dependency to the latest 3.0 beta version?

@jongbeau
Copy link
Author

It's actually using the 3.0.0-beta.4 version of node-sass.

@jongbeau jongbeau reopened this Mar 31, 2015
@jongbeau jongbeau reopened this Mar 31, 2015
@joostfarla
Copy link

I've tested with the latest libsass version, but the problem remains indeed. I guess we have to keep an eye on the related issue twbs/bootstrap-sass#879.

For now I've created a workaround by adding a custom requirement to my package.json, which points to an older (working) version of node-sass:

...
"node-sass": "sass/node-sass#v3.0.0-pre",
...

@Awem
Copy link

Awem commented Mar 31, 2015

@joostfarla the issue would be: sass/libsass#943 (as also linked in twbs/bootstrap-sass#879 (comment))
edit: just saw that you already mentioned that issue a few posts above. nevermind :-)

@jhnns
Copy link
Member

jhnns commented Mar 31, 2015

Thx for the feedback, but this error does not seem to be related to sass-loader...

@jhnns jhnns closed this as completed Mar 31, 2015
@Awem
Copy link

Awem commented Mar 31, 2015

@jhnns that's correct. node-sass is already a peerDepency. Nothing more can be done.

@ghost
Copy link

ghost commented Feb 9, 2017

+1

1 similar comment
@HamishClulee
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants