Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compatibility with node@8 #798

Merged
merged 1 commit into from
Jan 13, 2020
Merged

fix: compatibility with node@8 #798

merged 1 commit into from
Jan 13, 2020

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #797

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Jan 13, 2020

Codecov Report

Merging #798 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #798   +/-   ##
=======================================
  Coverage   97.75%   97.75%           
=======================================
  Files          10       10           
  Lines         178      178           
  Branches       63       63           
=======================================
  Hits          174      174           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b51d47...d41b1e5. Read the comment docs.

@alexander-akait alexander-akait merged commit 6f3852f into master Jan 13, 2020
@alexander-akait alexander-akait deleted the issue-797 branch January 13, 2020 13:01
@ronkorving
Copy link

Node 8 is EOL. Any reason to keep supporting it?

@alexander-akait
Copy link
Member Author

Because it is breaking change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sass loader 8.0.1 cannot be used in 8.16.2 node
2 participants