feat: add ValidationError

[michael-ciniawsky]

[michael-ciniawsky]

@bebraw @d3viant0ne please review

[codecov]

Codecov Report

Merging #8 into master will increase coverage by 10.78%.
The diff coverage is 94.11%.

@@             Coverage Diff             @@
##           master       #8       +/-   ##
===========================================
+ Coverage   83.33%   94.11%   +10.78%     
===========================================
  Files           2        3        +1     
  Lines           6       17       +11     
  Branches        2        3        +1     
===========================================
+ Hits            5       16       +11     
  Misses          1        1

Impacted Files	Coverage Δ
src/cjs.js	0% <0%> (ø)
src/ValidationError.js	100% <100%> (ø)
src/validateOptions.js	100% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7152276...f40a7cd. Read the comment docs.

[michael-ciniawsky]

Fixes #5 #6 #7

[joshwiens]

You keep defaulting to this testing approach and as I have said before, you negate most of the usefulness of using Jest.

• Jest doesn't require a build step as it's setup in defaults. babel-jest takes care of that.
• Jest runs tests async & only runs the tests related to the code you have changed, this negates that as well.
• None of the editor plugins for Jest work with this approach

[michael-ciniawsky]

Done

[michael-ciniawsky]

Anything else outstanding here ? Otherwise please merge and release I need this to move on with webpack-defaults 😛

[bebraw]

Yeah, I would merge this and get a new version out. Still a fresh package so better move fast.

[michael-ciniawsky]

It's MVP 😛 I intentionally avoided anything AJV 'advanced' for now and update schema-utils if we hit any limits with the current approach, but Load Schema => Validate Schema => Validate Options ? true : throw new ValidationError() works and should be fine for 90% of usecases in Loaders/Plugins, at least we can add it to all repos with the webpack-defaults upgrade and minor improvements follow :)

• webpack-defaults release with latest updates
• schema-utils release with this PR

and I'm rolling again 😛

⚠️ This is technically a breaking change, bc of ajv@5.0.0 (no $schema), but I'm aware of that especially for ETWP

[michael-ciniawsky]

@bebraw ping 😛

[joshwiens]

@michael-ciniawsky - Juho is still touring as far as I know so his availability is limited.

Given this is an internal tool and limited in deployment at the moment, as long as you are finished with this PR, I'll land it and publish a Major.

[michael-ciniawsky]

Juho is still touring as far as I know so his availability is limited

@d3viant0ne ohh.. sry I wasn't aware of that :)
Thx 👍 the PR is finished and additionally tested locally with a dummy loader/plugin && webpack

Loader === ${Name} in the screenshot 😛

[michael-ciniawsky]

@d3viant0ne Maybe this error format is better

ERROR in 'bla.js'
Module build failed: Validation Error
${Name} invalid options found: 

options.foo should be bar

ERROR in 'bla.js'
Module build failed:
VALIDATION ERROR in ${Name} 
Invalid options found: 

options.foo should be bar

?

[bebraw]

Let's go with this. The exact formatting can be tweaked later based on user feedback.

[michael-ciniawsky]

😛