Incorrect handling of esModule option

[dangreen]

https://github.com/webpack-contrib/style-loader/blob/master/src/index.js#L30

delete options.esModule;

https://github.com/webpack/loader-utils/blob/master/lib/getOptions.js

loaderUtils.getOptions doesn't copy options, just returns original object (loaderContext.query).

esModule option will be removed after first loader call, so farther calls will produce commonjs exports.

It breaks require imports:

require('./default.lazyModule.scss').default // undefined

Reproduction of this bug can be unstable, I think it caused by webpack's internal optimizations.

[alexander-akait]

Please use the issue template in future

[dangreen]

I think I can make PR with fix.

[alexander-akait]

Fixed in the master

[dangreen]

@evilebottnawi How soon release with this fix will published?

[alexander-akait]

I hope near future, we want to do mini-css-extract-plugin and style-loader releases together (set esModule: true), otherwise it can create problems for developers

[dangreen]

👌