Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: convert back-slashes #186

Merged
merged 1 commit into from
Oct 7, 2019
Merged

fix: convert back-slashes #186

merged 1 commit into from
Oct 7, 2019

Conversation

ricardogobbosouza
Copy link
Collaborator

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Resolve #185

Breaking Changes

Additional Info

@codecov-io
Copy link

codecov-io commented Oct 6, 2019

Codecov Report

Merging #186 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #186   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           6      6           
  Lines         102    102           
  Branches       20     20           
=====================================
  Hits          102    102
Impacted Files Coverage Δ
src/LintDirtyModulesPlugin.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b37d90...3b9c0a9. Read the comment docs.

@ricardogobbosouza ricardogobbosouza changed the title fix: escape back-slashes fix: convert back-slashes Oct 6, 2019
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add tests?

@vidal7
Copy link

vidal7 commented Oct 7, 2019

I can confirm you that this change fixes this issue (#185). Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lintDirtyModulesOnly doesn't works on Windows
4 participants