fix: options variable in apply function #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #193 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 6 6
Lines 102 102
Branches 20 20
=====================================
Hits 102 102
Continue to review full report at Codecov.
|
|
@ktmouk thanks |
|
@ktmouk - appreciate the quick turnaround on this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Fix: #191
Currently,
optionsvariable is shallow copy. (const { options } = this)When webpack has config multiple and
fileis relative,.join(context, '/', file)will be called multiple times.So,
options.filespath is broken.Breaking Changes
Nothing
Additional Info