Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make possible to define official formatter as string #202

Merged
merged 1 commit into from
Jan 13, 2020

Conversation

ricardogobbosouza
Copy link
Collaborator

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

The formatter option only accepted function, with this feature we can also set official formatters as string

const StylelintPlugin = require('stylelint-webpack-plugin');

module.exports = {
  // ...
  plugins: [
    new StylelintPlugin({
      formatter: 'json' // See https://stylelint.io/user-guide/node-api#formatter
    )
  ],
  // ...
};

Additional Info

Resolve #201

@codecov-io
Copy link

codecov-io commented Jan 6, 2020

Codecov Report

Merging #202 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #202   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           6      6           
  Lines         112    121    +9     
  Branches       24     27    +3     
=====================================
+ Hits          112    121    +9
Impacted Files Coverage Δ
src/getOptions.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75a9ef4...586e0ac. Read the comment docs.

@ricardogobbosouza ricardogobbosouza merged commit 8d6599c into master Jan 13, 2020
@ricardogobbosouza ricardogobbosouza deleted the feat-formatter branch January 13, 2020 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve formatter option docs
2 participants