Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use better micromatch extglobs #216

Conversation

bahmannejati
Copy link
Contributor

This PR contains a:

  • bugfix
  • typo fix

Motivation / Use-Case

It seems that the default value for the files option has an issue.
If the purpose of **/*.s?(c|a)ss is to match just scss or sass files so why we need ? after s
I think the **/*.(s(c|a)ss|css) is better for supporting css, scss & sass files.

@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2020

Codecov Report

Merging #216 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #216   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          125       125           
  Branches        25        25           
=========================================
  Hits           125       125           
Impacted Files Coverage Δ
src/getOptions.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7cfe0a...496c32e. Read the comment docs.

@ricardogobbosouza ricardogobbosouza merged commit a70ed3d into webpack-contrib:master Jul 29, 2020
@ricardogobbosouza
Copy link
Collaborator

Thanks @bahmannejati

@tagliala
Copy link
Contributor

Hi,

I think this can be considered a breaking change, my builds break with 2.1.1

Also the readme should be updated to reflect this change

tagliala added a commit to tagliala/stylelint-webpack-plugin that referenced this pull request Oct 16, 2020
webpack-contrib#216 introduced a new default value for files option. This commit
reflects the change
tagliala added a commit to diowa/icare that referenced this pull request Oct 24, 2020
tagliala added a commit to diowa/ruby2-rails5-bootstrap-heroku that referenced this pull request Oct 24, 2020
tagliala added a commit to diowa/ruby3-rails6-bootstrap-heroku that referenced this pull request Oct 24, 2020
@icatalina
Copy link

Hi @ricardogobbosouza! Could we please revert this and release it as a breaking change. An npm audit is breaking all our builds.

Thanks!

ricardogobbosouza pushed a commit that referenced this pull request Nov 12, 2020
#216 introduced a new default value for files option. This commit
reflects the change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants