fix: remove outdated stylelint types

[rchl]

This PR contains a:

• bugfix
• new feature
• code refactor
• test update
• typo fix
• metadata update

Motivation / Use-Case

The @types/stylelint package is for Stylelint 13. Stylelint 14 includes type declarations already.

The issue with installing this dependency in a project that uses Stylelint 14+ is that it includes outdated "postcss" (v7) dependency that might cause issues in the host project.

Breaking Changes

For projects that are still using Stylelint 13 this could potentially be a breaking change (if the project interacts with stylelint related types directly). The fix would be to add @types/stylelint dependency manually in the project.

Even though this is potentially a breaking change, bumping to next major version is not really an option since it's already taken.

Additional Info

@ricardogobbosouza

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ Rafał Chłodnicki (5b8d3cd)

[alexander-akait]

I see, but in this case we will break, stylelint v13 usage... but we can say in docs about using other types for v13

[rchl]

Yes, I've added comment about that already. @types/stylelintis for stylelint 13. Stylelint 14 includes types already.

I believe that majority of use cases will not actually require types but there is always a chance of this breaking someone's use case.

[ricardogobbosouza]

@rchl I just didn't understand why the tests failed

[rchl]

Looks like npm started using ES syntax that doesn't work anymore in Node 10.

[skjnldsv]

Looks like npm started using ES syntax that doesn't work anymore in Node 10.

lts is 16, maybe it's start removing support for node 10? 🤔

[skjnldsv]

Thank you everyone involved! 🎉
Happy new year (it's not too late, isn't it? 😁)

[skjnldsv]

Should it be ported to master too?

[NLueg]

@skjnldsv it should definitely ported to master in my opinion.
We also have an issue with the 3.1.0 version:

postcss  <8.2.13
Severity: moderate
Regular Expression Denial of Service in postcss - https://github.com/advisories/GHSA-566m-qj78-rww5
fix available via `npm audit fix --force`
Will install stylelint-webpack-plugin@2.1.1, which is a breaking change
node_modules/@types/stylelint/node_modules/postcss
  @types/stylelint  9.10.0 - 13.13.3
  Depends on vulnerable versions of postcss
  node_modules/@types/stylelint
    stylelint-webpack-plugin  >=2.2.0
    Depends on vulnerable versions of @types/stylelint
    node_modules/stylelint-webpack-plugin

3 moderate severity vulnerabilities

[alexander-akait]

@ricardogobbosouza friendly ping, we should port it to master

[ricardogobbosouza]

Released v2.3.2 and v3.1.1