Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance optimization suggestion, lint only failed files + changed files #54

Closed
sergesemashko opened this issue Jan 4, 2017 · 2 comments

Comments

@sergesemashko
Copy link
Contributor

sergesemashko commented Jan 4, 2017

On my current project introducing stylelint raised watch build time from ~3s to ~25s. I guess, it happened because of big amount of files and amount of rules.

So, maybe we could cache files that failed to lint on initial run and then include them + files that changed for linting. That should decrease overhead from linting all the files that passed initially and hasn't been changed.

It seems this will require slight update how to deal with stylelint formatter, because in order to get failed files it would require both JSON and string output.

If this suggestion sounds good, I'd be happy to poke around and apply the optimization.

@sergesemashko sergesemashko changed the title Performance optimization suggestion, lint only initially failed files + changed files Performance optimization suggestion, lint only failed files + changed files Jan 5, 2017
@JaKXz
Copy link
Contributor

JaKXz commented Apr 1, 2017

@sergesemashko this was implemented with lintDirtyModulesOnly right?

@sergesemashko
Copy link
Contributor Author

@JaKXz, correct.
BTW, cache option was added to stylelint. So, if someone has performance issues, that flag can dramatically decrease lint time.

@JaKXz JaKXz closed this as completed Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants