fix(perf): avoud using clona for stylus options
#394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
commented
Jun 8, 2023
| @@ -249,15 +249,15 @@ describe("loader", () => { | |||
| const testId = "./shallow-deep-literal.styl"; | |||
| const compiler = getCompiler(testId, { | |||
| stylusOptions: { | |||
| dest: "deep/deep-literal.css", | |||
| dest: path.resolve(__dirname, "fixtures/"), | |||
There was a problem hiding this comment.
Side effect after fixing logic, because developer can pass own options for source maps, we need to allow to change it too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Better perf and less deps
Breaking Changes
No
Additional Info
Added test which allow to override source map options, I think we need to implement this for other CSS like loaders, but it will be separately