Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: addBuildDependency support #117

Merged

Conversation

WearyMonkey
Copy link
Contributor

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

postcss-loader uses addBuildDependency when loading a config.

https://github.com/webpack-contrib/postcss-loader/blob/master/src/utils.js#L66

Additional Info

@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #117 (cf1136c) into master (0dbea4d) will increase coverage by 0.03%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
+ Coverage   21.03%   21.06%   +0.03%     
==========================================
  Files           8        8              
  Lines         485      489       +4     
  Branches       94       94              
==========================================
+ Hits          102      103       +1     
- Misses        335      338       +3     
  Partials       48       48              
Impacted Files Coverage Δ
src/worker.js 0.00% <0.00%> (ø)
src/index.js 65.21% <100.00%> (+1.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dbea4d...cf1136c. Read the comment docs.

@alexander-akait alexander-akait merged commit 1c7a8a2 into webpack-contrib:master May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants