Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

Different default limit values in documentation #223

Closed
1 of 4 tasks
JoshuaKGoldberg opened this issue Dec 8, 2020 · 3 comments · Fixed by #224
Closed
1 of 4 tasks

Different default limit values in documentation #223

JoshuaKGoldberg opened this issue Dec 8, 2020 · 3 comments · Fixed by #224

Comments

@JoshuaKGoldberg
Copy link
Contributor

Documentation Is:

  • Missing
  • Needed
  • Confusing
  • Not Sure?

Please Explain in Detail...

In README.md, the big table of options lists true as the default value for limit. Just after the table, the section for specifically limit lists its default as undefined.

Your Proposal for Changes

Pick one and stick with it. :)
@alexander-akait
Copy link
Member

Because it is default value, all files will be converted to data:

@alexander-akait
Copy link
Member

Oh, I see, sorry

@alexander-akait
Copy link
Member

Yep, feel free to fix it, default value is undefined

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 8, 2020
Merged
6 tasks
JoshuaKGoldberg referenced this issue in vivcogit/url-loader Mar 15, 2021
@JoshuaKGoldberg
docs: corrected limit as undefined in docs (webpack-contrib#224)
fa6cf3f
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Corrected limit as undefined in docs
2 participants
@JoshuaKGoldberg @alexander-akait