This repository has been archived by the owner on Mar 17, 2021. It is now read-only.
feat(index): add options validation (schema-utils)
#78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json
Outdated
| @@ -5,7 +5,8 @@ | |||
| "description": "url loader module for webpack", | |||
| "dependencies": { | |||
| "loader-utils": "^1.0.2", | |||
| "mime": "1.3.x" | |||
| "mime": "1.3.x", | |||
There was a problem hiding this comment.
why don't use "mime": "^1.3.0"?
michael-ciniawsky
force-pushed
the
schema
branch
3 times, most recently
from
3356f91
to
fb3ad55
Compare
|
Any objections against this PR, I would like to continue adding |
alexander-akait
suggested changes
Jun 13, 2017
package.json
Outdated
| @@ -9,7 +9,8 @@ | |||
| }, | |||
| "dependencies": { | |||
| "loader-utils": "^1.0.2", | |||
| "mime": "1.3.x" | |||
| "mime": "1.3.6", | |||
There was a problem hiding this comment.
why without ^, this will force us to constantly update and spend for this time 😞
michael-ciniawsky
force-pushed
the
schema
branch
from
fb3ad55
to
5c04e50
Compare
alexander-akait
approved these changes
Jun 13, 2017
bebraw
approved these changes
Jun 13, 2017
joshwiens
approved these changes
Jun 13, 2017
This was referenced Apr 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.