Skip to content
This repository has been archived by the owner on Jul 13, 2021. It is now read-only.

Browser not reloading on unaccepted changes #26

Closed
1 of 3 tasks
mgoggin opened this issue Mar 4, 2018 · 3 comments
Closed
1 of 3 tasks

Browser not reloading on unaccepted changes #26

mgoggin opened this issue Mar 4, 2018 · 3 comments

Comments

@mgoggin
Copy link

mgoggin commented Mar 4, 2018

  • Operating System: Darwin 17.4.0
  • Node Version: 9.6.1
  • NPM Version: 5.6.0
  • webpack Version: 4.0.1
  • webpack-hot-client Version: 2.0.0
  • This is a bug
  • This is a feature request
  • This is a modification request

Code

You can clone the repo at mgoggin/react-app for an example.

Expected Behavior

When a project file is changed and that module is unaccepted by webpack-hot-client and reload is configured as true, the browser should reload to pull down the newest changes.

Actual Behavior

Webpack compiles the project and the update is sent to the browser, but nothing changes since the module is unaccepted, even though reload is explicitly set to true.

For Bugs; How can we reproduce the behavior?

@shellscape
Copy link
Contributor

Thanks for the solid issue 🍺 We'll take a look at this, but if you get the itch to open a PR that'd be cool too.

@pqml
Copy link
Contributor

pqml commented Mar 5, 2018

I made a PR for this one #28

@shellscape
Copy link
Contributor

Closed by #28

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants