Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reloading stops on syntax errors #69

Closed
bayov opened this issue Feb 5, 2016 · 5 comments
Closed

Reloading stops on syntax errors #69

bayov opened this issue Feb 5, 2016 · 5 comments

Comments

@bayov
Copy link

bayov commented Feb 5, 2016

Whenever the middleware encounters a syntax error, hot-reloading stops.

The browser is first notified of the error, and displays the error on a red background (all good...). But then no new HMR notifications are received and it seems like the server stops watching for new changes.

I tested this on Windows 10, using:

webpack@2.0.5-beta
webpack-dev-middleware@1.5.1
webpack-hot-middleware@2.6.4
@glenjamin
Copy link
Collaborator

I've not done much testing on webpack v2 yet - does this also happen on webpack v1?

@bayov
Copy link
Author

bayov commented Feb 6, 2016

Does not happen using webpack@1.12.13

@glenjamin
Copy link
Collaborator

This will either be a bug, or a change in the HMR APIs - I'll see about having a look into what, if anything, has changed.

@glenjamin
Copy link
Collaborator

Should be resolved with #85 and #86

Released as 2.10.0

@arpitgo4
Copy link

Hi,

I have been creating a scaffold with react-redux and webpack for hot reloading.
At first, hot reloading works good, but after any syntax error webpack-hot-middleware/client stops checking for updates on the server and hot reloading. It just shows the bundle rebuilding status.

I am using:
Windows 10
"webpack": "^2.4.1"
"webpack-dev-middleware": "^1.10.2",
"webpack-hot-middleware": "^2.18.0"

Repository for verifying the issue:
https://github.com/arpitgo4/React-Redux-Scaffold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants