Skip to content
This repository has been archived by the owner on Apr 8, 2019. It is now read-only.

Hot client port seems to be ignored #218

Closed
1 of 3 tasks
MatTheCat opened this issue Jul 10, 2018 · 3 comments
Closed
1 of 3 tasks

Hot client port seems to be ignored #218

MatTheCat opened this issue Jul 10, 2018 · 3 comments

Comments

@MatTheCat
Copy link

MatTheCat commented Jul 10, 2018

  • Operating System: Alpine 3.7.0
  • Node Version: 10.6.0
  • NPM Version: 6.1.0
  • webpack Version: 4.15.1
  • webpack-serve Version: 2.0.2
  • webpack-hot-client Version: 4.1.0

This issue is for a:

  • bug
  • feature request
  • modification request
CLI Command
  $ webpack-serve docs/webpack.config.js
serve.config.js
module.exports = {
  clipboard: false,
  devMiddleware: {
    publicPath: '/pattern-library/dist/'
  },
  hotClient: {
    allEntries: true,
    host: {
      client: '*',
      server: '127.0.0.1'
    },
    port: {
      client: 8082,
      server: 8081
    }
  },
  host: '0.0.0.0'
}

Expected Behavior

Websocket client uses client port 8082.

Actual Behavior

Websocket client try using server port 8081 and fails.

How Do We Reproduce?

Set hotClient.port as an object.

@MatTheCat
Copy link
Author

MatTheCat commented Jul 10, 2018

Maybe this is a webpack-hot-client issue. options.webSocket.port changes between modifyCompiler call (where it has the right value) and beforeCompile event (where it takes value from port.server).

No idea why this happens.

@shellscape
Copy link
Contributor

Yeah, that's an issue for webpack-hot-client. Please open it up over at https://github.com/webpack-contrib/webpack-hot-client

@MatTheCat
Copy link
Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants