AliasFieldPlugin.apply + lodash: resolving the wrong toString

[Fconstant]

When resolving "./toString" from lodash, data2 on AliasFieldPlugin.js is removing the ./ from "./toString" of lodash, causing fieldData to get the default function toString() of every object.

Resulting in:

       var idxQuery = identifier.indexOf("?");
                                  ^

TypeError: identifier.indexOf is not a function
    at Resolver.parse (/Users/fcconstantino/Projects/@products/@crefisa/NetBankApp/node_modules/enhanced-resolve/lib/Resolver.js:181:28)
    at Resolver.<anonymous> (/Users/fcconstantino/Projects/@products/@crefisa/NetBankApp/node_modules/enhanced-resolve/lib/ParsePlugin.js:17:25)
    at Resolver.applyPluginsAsyncSeriesBailResult1 (/Users/fcconstantino/Projects/@products/@crefisa/NetBankApp/node_modules/tapable/lib/Tapable.js:256:13)
    at runNormal (/Users/fcconstantino/Projects/@products/@crefisa/NetBankApp/node_modules/enhanced-resolve/lib/Resolver.js:130:20)
    at Resolver.doResolve (/Users/fcconstantino/Projects/@products/@crefisa/NetBankApp/node_modules/enhanced-resolve/lib/Resolver.js:116:3)
    at Resolver.<anonymous> (/Users/fcconstantino/Projects/@products/@crefisa/NetBankApp/node_modules/enhanced-resolve/lib/UnsafeCachePlugin.js:37:12)
    at Resolver.applyPluginsAsyncSeriesBailResult1 (/Users/fcconstantino/Projects/@products/@crefisa/NetBankApp/node_modules/tapable/lib/Tapable.js:256:13)
    at runNormal (/Users/fcconstantino/Projects/@products/@crefisa/NetBankApp/node_modules/enhanced-resolve/lib/Resolver.js:130:20)
    at Resolver.doResolve (/Users/fcconstantino/Projects/@products/@crefisa/NetBankApp/node_modules/enhanced-resolve/lib/Resolver.js:116:3)
    at Resolver.<anonymous> (/Users/fcconstantino/Projects/@products/@crefisa/NetBankApp/node_modules/enhanced-resolve/lib/AliasFieldPlugin.js:49:12)

Something I couldn't find is: Who is calling the AliasFieldPlugin?

A simple and easy fix was to do something like this:

if (typeof data === 'function') {
    return callback();
}

OBS: I'm also using Haul, which uses an older version of webpack, but still the latest version of enhanced-resolve

Using	Version
npm	5.4.2
webpack	2.7.0
enhanced-resolve	3.4.1
lodash	4.17.4
haul	1.0.0-beta.5

[omatrot]

I have the same error using sjcl in a ReactJS app (webpack). Works fine in React Native (Babel) though.

[omatrot]

Solved it by replacing sjcl with jwt-decode because I only need to deal with JWT Tokens

[sokra]

Send a PR.

Object.prototype.hasOwnProperty.call(someObject, someProperty)

[Fconstant]

@sokra Sorry, I didn't understand what you meant. What am I supposed to do with hasOwnProperty?

[domoritz]

Could this be causing jupyterlab/jupyter-renderers#91?

[Fconstant]

@domoritz Almost. In your case identifier is null. In this case, identifier is not null but indexOf is not a function. But it is the same location that triggers the error.

[dylanslade]

Has any progress been made?

[alexander-akait]

Need reproducible test repo, thanks!

[sentenza]

The only workaround I found for this issue is adding:

"browser": {
    "crypto": true
  }

to my package.json. @evilebottnawi you can find the repo here

[ghost]

Is @sentenza workaround working for everyone ? Didnt solve it for me..

[khalidhoffman]

@ArThoX I think you may just need to pass some path string instead of a boolean

[alexander-akait]

I think here the problem with package.json, maybe somebody can create reproducible test repo?

[sokra]

I think we need to check hasOwnProperty to avoid receiving Object prototype methods

[alexander-akait]

Yep, just want to find broken example

[pmmmwh]

I think this will break reliably - a couple helpers in lodash mutates function prototype, in particular anything related to _setToString (e.g. sortBy)

{
  "dependencies": {
    "@pmmmwh/react-refresh-webpack-plugin": "0.5.x",
    "expo": "*"
  },
  "scripts": {
    "start": "expo web"
  }
}

The issue creeps in via whatwg-url which internally uses lodash/sortBy.
(Ref: pmmmwh/react-refresh-webpack-plugin#601)

[vankop]

yeah, this should be fixed..