Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conditionNames defaults to ["node"] according to docs, but possibly doesn't actually #358

Closed
43081j opened this issue Oct 19, 2022 · 2 comments · Fixed by #359
Closed

conditionNames defaults to ["node"] according to docs, but possibly doesn't actually #358

43081j opened this issue Oct 19, 2022 · 2 comments · Fixed by #359

Comments

@43081j
Copy link
Contributor

43081j commented Oct 19, 2022

the readme specifies:

| conditionNames | ["node"] | A list of exports field condition names |

however:

conditionNames: new Set(options.conditionNames),

seems here we don't actually default the condition names array to anything, so later on the various plugins receive and empty set.

should it possibly be this instead:

conditionNames: new Set(options.conditionNames || ['node']),
@alexander-akait
Copy link
Member

alexander-akait commented Oct 20, 2022

@43081j Yeah, I think we should to fix a docs, because change it in the current version will be a breaking change

@43081j
Copy link
Contributor Author

43081j commented Oct 20, 2022

makes sense to me, ill open a PR at some point if someone doesn't beat me to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants