We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
["node"]
the readme specifies:
enhanced-resolve/README.md
Line 86 in 651e578
however:
enhanced-resolve/lib/ResolverFactory.js
Line 194 in 651e578
seems here we don't actually default the condition names array to anything, so later on the various plugins receive and empty set.
should it possibly be this instead:
conditionNames: new Set(options.conditionNames || ['node']),
The text was updated successfully, but these errors were encountered:
@43081j Yeah, I think we should to fix a docs, because change it in the current version will be a breaking change
Sorry, something went wrong.
makes sense to me, ill open a PR at some point if someone doesn't beat me to it
Successfully merging a pull request may close this issue.
the readme specifies:
enhanced-resolve/README.md
Line 86 in 651e578
however:
enhanced-resolve/lib/ResolverFactory.js
Line 194 in 651e578
seems here we don't actually default the condition names array to anything, so later on the various plugins receive and empty set.
should it possibly be this instead:
The text was updated successfully, but these errors were encountered: