Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rework oneOf error output (#48) #50

Merged
merged 1 commit into from Sep 2, 2019
Merged

feat: rework oneOf error output (#48) #50

merged 1 commit into from Sep 2, 2019

Conversation

vankop
Copy link
Member

@vankop vankop commented Aug 16, 2019

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

closes #48

Breaking Changes

no

Additional Info

Now all oneOf/anyOf that contains exactly one child in schema, i.e.

{
    anyOf: [{ type: string }] 
}

will be skipped in favor of their child, so it won't produce additional output:

Details: ...
   string
   Details: <children info>

If this behavior need to be fixed I can change it

@alexander-akait
Copy link
Member

/cc @sokra

alexander-akait
alexander-akait approved these changes Sep 2, 2019
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@alexander-akait alexander-akait merged commit 332242f into webpack:master Sep 2, 2019
@vankop vankop deleted the issue-48 branch September 2, 2019 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

improve output in some cases
2 participants
@vankop @alexander-akait