feat: definitions #52
Conversation
|
It is small and we can fix version |
|
@vankop we need avoid extra deps, because this is used inside webpack, we need keep libraries as small as possible and no extra deps, maybe we can move declaration inside? |
so... copy paste? |
|
@vankop yep, copy/paste |
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
=======================================
Coverage 98.51% 98.51%
=======================================
Files 4 4
Lines 472 472
Branches 215 215
=======================================
Hits 465 465
Misses 7 7Continue to review full report at Codecov.
|
|
I was curious to create babel plugin for extracting JSON schema definitions on build, but looks like it will be overengineering for |
|
@evilebottnawi could you review this, please? |
|
@vankop near future, some busy |
| ValidateError: typeof SchemaUtils.ValidateError | ||
| } | ||
|
|
||
| export = validate; |
There was a problem hiding this comment.
Why don't add some types in devDeps?
There was a problem hiding this comment.
Hmmm, I just followed your previous suggestions -( Ok i will revert this and move this to dev dependency
There was a problem hiding this comment.
@vankop Sometimes I have a lot issues and lose context, sorry for that, all make mistakes 😄
# Conflicts: # package.json
|
I think not since it design to create definitions from code and not vice versa. |
|
@vankop hm, what about this https://github.com/sindresorhus/execa/blob/master/index.test-d.ts? |
|
I will take a look, if you think we need some tests |
|
@vankop let's open new issue about this, I think everything is fine here. |
This PR contains a:
Motivation / Use-Case
#49
Breaking Changes
No
Additional Info
Nothing