fix: displayStats only logged (#427)

* fix: displayStats only logged * test: should not print stats if options.stats without content
webpack · Jul 8, 2019 · 98deaf4 · 98deaf4
1 parent dff39a1
commit 98deaf4
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 4 deletions.
diff --git a/lib/reporter.js b/lib/reporter.js
@@ -5,14 +5,16 @@ module.exports = function reporter(middlewareOptions, options) {
 
   if (state) {
     const displayStats = middlewareOptions.stats !== false;
+    const statsString = stats.toString(middlewareOptions.stats);
 
-    if (displayStats) {
+    // displayStats only logged
+    if (displayStats && statsString.trim().length) {
       if (stats.hasErrors()) {
-        log.error(stats.toString(middlewareOptions.stats));
+        log.error(statsString);
       } else if (stats.hasWarnings()) {
-        log.warn(stats.toString(middlewareOptions.stats));
+        log.warn(statsString);
       } else {
-        log.info(stats.toString(middlewareOptions.stats));
+        log.info(statsString);
       }
     }
 

diff --git a/test/reporter.test.js b/test/reporter.test.js
@@ -165,6 +165,25 @@ describe('Reporter', () => {
     });
   });
 
+  it('should not print stats if options.stats without content', (done) => {
+    const statsWithoutContent = Object.assign({}, stats, {
+      toString: () => '',
+    });
+    const instance = middleware(
+      compiler,
+      Object.assign(defaults, { stats: statsWithoutContent })
+    );
+    const { log } = instance.context;
+    spy(instance);
+    hooks.done(statsWithoutContent);
+
+    setTimeout(() => {
+      expect(log.info).toBeCalledTimes(1);
+      expect(log.info.mock.calls[0][0]).toBe('Compiled successfully.');
+      done();
+    });
+  });
+
   it('should print: wait until bundle valid', (done) => {
     const instance = middleware(compiler, defaults);
     const { log } = instance.context;