Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: directly used mkdirp instead of through Webpack #436

Merged
merged 1 commit into from Jul 8, 2019
Merged

fix: directly used mkdirp instead of through Webpack #436

merged 1 commit into from Jul 8, 2019

Conversation

JoshuaKGoldberg
Copy link
Contributor

Fixes Webpack 5 usage by no longer requiring the removed webpack/lib/node/NodeOutputFileSystem

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Fixes #435.

Breaking Changes

Introduces dependency on mkdirp, which was only transient through webpack before.

Fixes Webpack 5 usage by no longer requiring the removed webpack/lib/node/NodeOutputFileSystem
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @hiroppy

@hiroppy hiroppy merged commit dff39a1 into webpack:master Jul 8, 2019
@hiroppy
Copy link
Member

hiroppy commented Jul 8, 2019

Thanks.

@JoshuaKGoldberg JoshuaKGoldberg deleted the mkdirp-direct branch July 8, 2019 20:55
@zackify
Copy link

zackify commented Aug 27, 2019

When will a new release be cut?

@jpreynat
Copy link

Could we please have a release to benefit from this update and use it again with latest versions of webpack 5?

@alexander-akait
Copy link
Member

In TODO, release will be tomorrow

@jpreynat
Copy link

Great, thanks @evilebottnawi

@natew
Copy link

natew commented Sep 2, 2019

Any word on releasing this?

@alexander-akait
Copy link
Member

@natew yes, today, we find some problems with api and redesigning it in the next version, so it took us a little longer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webpack/lib/node/NodeOutputFileSystem removed in Wepback 5
6 participants