Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update peerDependencies to support webpack@^5.0.0 for webpack-dev-middleware@^3.7.2 #797

Closed
hiwangyi opened this issue Dec 15, 2020 · 1 comment · Fixed by #798
Closed

Comments

@hiwangyi
Copy link

Feature Proposal

Add webpack@^5.0.0 as a valid peer dependency for webpack-dev-middleware@^3.7.2

Feature Use Case

webpack-dev-middleware started to support webpack@5 from v3.7.2. Actually, the peerDependencies in package.json of v3.7.2 only contains webpack@^4.0.0.
webpack-dev-middleware@^3.7.2 is the dependency of webpack-dev-server@3.11.0. If webpack@5 and webpack-dev-server@3.11.0 are used at the same time, a warning message will be thrown when installing the dependencies:

warning "webpack-dev-server > webpack-dev-middleware@3.7.2" has incorrect peer dependency "webpack@^4.0.0".
@alexander-akait
Copy link
Member

Please try https://github.com/webpack/webpack-dev-middleware/releases/tag/v3.7.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants