Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to webpack-cli v.3.3.x #1753

Closed
evenstensberg opened this issue Apr 1, 2019 · 1 comment · Fixed by #1754
Closed

Upgrade to webpack-cli v.3.3.x #1753

evenstensberg opened this issue Apr 1, 2019 · 1 comment · Fixed by #1754

Comments

@evenstensberg
Copy link
Member

Just a heads up

When doing this, remember to update the location of config-yargs.js, it has changed. Maybe some other sources has changed too, so check where you import directly from the library.

@EslamHiko
Copy link
Member

Hello @evenstensberg
I did a PR to update the paths of both config-yargs & convert-argv
I upgraded webpack-cli to the master branch and I run npm test cli.test on my machine and it passes the test however in AppVeyor testing it doesn't pass the test
on my machine, if I returned the paths to their origin it won't pass the test
I tried to upgrade webpack to it's latest version but it's still not passing the test
I got an idea to check if the new module with the new path exists or not and if it doesn't exist fall back to the original path so it can work with all versions v3.3.x and v3.2.x but I got that error 85:1 error Calls to require() should use string literals import/no-dynamic-require
so what did I miss here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants