Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSoC Refactor: CLI Refactor (CLI/API Uniformity Improvements, webpack-cli serve) #1960

Closed
5 tasks
knagaitsev opened this issue Jun 4, 2019 · 3 comments
Closed
5 tasks

Comments

@knagaitsev
Copy link
Collaborator

knagaitsev commented Jun 4, 2019

I decided to separate this from the clientMode/serverMode refactor effort. Here are my plans:

  • make any "CLI Only" options available to API as well (e.g. devServer.progress)
  • bring options handling in bin/webpack-dev-server to a bare minimum
  • minimize createConfig such that it only normalizes CLI arguments to API options, but does not handle defaults. Instead, the API should handle setting defaults.
  • move the logic of bin/webpack-dev-server into webpack-cli serve, such that webpack-cli serve calls the Dev Server API.

Issue created at webpack-cli: webpack/webpack-cli#900

EDIT:

  • make the CLI throw an error (or possibly just a warning for backwards compatability?) if an argument is provided that does not exist
@knagaitsev knagaitsev changed the title GSoC Refactor: CLI Refactor (CLI/API Uniformity Improvements) GSoC Refactor: CLI Refactor (CLI/API Uniformity Improvements, webpack-cli serve) Jun 4, 2019
@Parikshit-Hooda
Copy link

@hiroppy we can close this issue now.

@alexander-akait
Copy link
Member

Still no

@alexander-akait
Copy link
Member

Let's close, it is done, but with some bugs, but, we will fix them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants