-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
process.env should not be attached inside window object #2904
Comments
webpack itself doesn't add that. maybe webpack-dev-server @alexander-akait ? |
Hi @sokra , check the first lines of code of this, I think you are right: https://github.com/webpack/webpack-dev-server/blob/b0161e9852cdf41730e82aa43efe7e88f44a4f9d/client-src/default/index.js. |
Yep, @vanbasten17 known but, we are working on it |
cool @alexander-akait, let me know if you need feedback after the change. By the way, do you know when will be a stable release for webpack-dev-server v4? |
Sorry, no, but I think this month, it is already stable in 99% cases so you can use it |
Is there any progress on this issue @alexander-akait |
Same issue here with latest versions of all webpack - related packages with IE 11, than the one reported on #2918 'Symbol' is undefined https://github.com/webpack/webpack-dev-server/blob/master/client-src/transpiled-modules/log.js |
@alexander-akait This issue sadly completely blocks IE11. With dev-server 3.11.2 HMR doesn't work (because it requires target: ['web', 'es5']), but with dev-server 4.0.0 beta IE11 doesn't work at all due to Symbol/Object.assign errors. Just donated some to opencollective, I hope it helps a bit |
Yep, with this week, I am fully focus on webpack-dev-server, IE 11 will be fixed in the next release |
Fixed #2971, sorry for delay, really many issues |
@alexander-akait hey Alex, I've started trying to migrate to W5, but these IE11 (God help it die ASAP!) issues are really blocking for us. Any ETA on this fix published? Beta could also work 😃 |
Hope this week |
Any news on this? |
WIP on IE 11 compatibility |
How about ie 10 ? |
Bug report
What is the current behavior?
Just setted a set of compilation rules to compile a web project along with webpack-dev-server, here's an example:
After running the command
webpack serve --env target=dev --mode=development
and opening the browser,process
object comes inside the definition ofwindow
object (attached screenshot), withenv
set as an empty object. See that I'm not using any kind of Environment or Define Plugin, I don't want to have process defined. In previous versions (webpack 4), this variable was undefined (as far as I understand, this should be the common behavior).If the current behavior is a bug, please provide the steps to reproduce.
After setting above rules,
What is the expected behavior?
process.env
should not be attached by default. It should be enabled (in any case) after using some of the plugins to define env variables.Other relevant information:
webpack version: 5.9.0
Node.js version:
v10.23.0
, also triedv12.20.0
with same results.Operating System: macOS Catalina 10.15.7
Additional tools:
The text was updated successfully, but these errors were encountered: