fix: support file: and chrome-extension: protocols in client #2954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2954 +/- ##
==========================================
- Coverage 92.54% 92.39% -0.15%
==========================================
Files 37 37
Lines 1261 1263 +2
Branches 334 328 -6
==========================================
Hits 1167 1167
- Misses 89 91 +2
Partials 5 5
Continue to review full report at Codecov.
|
ylemkimon
reviewed
Jan 2, 2021
vespakoen
force-pushed
the
fix-nwjs-compat
branch
2 times, most recently
from
f20a98d
to
25b92e3
Compare
vespakoen
force-pushed
the
fix-nwjs-compat
branch
from
25b92e3
to
e1ab7a4
Compare
alexander-akait
approved these changes
Jan 3, 2021
This was referenced Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Yes, I added tests to check if the protocol was changed, it is poking at variables inside of WebSocket and SockJS though, this is probably not the most stable way to do this, but I am not sure how to mock those or if that is even necessary.
Motivation / Use-Case
When using node-webkit, or electron, the protocol can be
file:orchrome-extension:, causing the websocket or sockjs to try to connect to an incorrect url, for example:file://localhost:8080/wsorchrome-extension://localhost:8080/ws.This PR changes it to the correct behaviour.
Breaking Changes
This PR should not be a breaking change.
Additional Info
I just noticed I also replace
httpswithws, this should probably be an extra case where it is replaced withwss.EDIT: I removed the https case