Proxy without target

[lukasgeiter]

• This is a bug
• This is a modification request

Code

devServer: {
    proxy: {
        '/api': {
            target: 'dummy', // shouldn't be necessary
            router: request => ...
        },
    },
},

Expected Behavior

I expect to be able to use the router feature of http-proxy-middleware without having to specify a target.

Actual Behavior

When target is missing, the proxy middleware is not used at all:

webpack-dev-server/lib/Server.js

Lines 281 to 283 in 516d7b1

	if (proxyConfig.target) {
	return createProxyMiddleware(context, proxyConfig);
	}

Which is also noted in the documentation:

Note that some of http-proxy-middleware's features do not require a target key, e.g. its router feature, but you will still need to include a target key in your configuration here, otherwise webpack-dev-server won't pass it along to http-proxy-middleware).

Recently, the validation in http-proxy-middleware has been updated to allow for configurations without a target key. I suggest to do the same here and extend the condition to proxyConfig.target || proxyConfig.router.

[anshumanv]

makes sense, I'll fix it 👍

[alexander-akait]

You can use target '**'

[lukasgeiter]

@alexander-akait As far as I can tell, I can use pretty much any value I want as long as it's truthy. Currently I'm using 'dummy' which is working fine. The point is, I shouldn't have to specify a target if it's always going to be overridden by router anyway.