Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow to use 80 port for dev server #3487

Merged
merged 3 commits into from Jun 28, 2021

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

WIP

Motivation / Use-Case

Allow to use 80 port, also simplify our logic and avoid creating URL in favor query params, it is more flexibly

Breaking Changes

Yes, if somebody use client entry directly, I will describe it in migration guide

Additional Info

No

@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #3487 (992be8e) into master (b559738) will increase coverage by 0.63%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3487      +/-   ##
==========================================
+ Coverage   94.20%   94.84%   +0.63%     
==========================================
  Files          26       25       -1     
  Lines        1311     1299      -12     
  Branches      416      412       -4     
==========================================
- Hits         1235     1232       -3     
+ Misses         71       63       -8     
+ Partials        5        4       -1     
Impacted Files Coverage Δ
client-src/index.js 88.23% <100.00%> (+5.04%) ⬆️
client-src/utils/createSocketURL.js 100.00% <100.00%> (+3.57%) ⬆️
client-src/utils/parseURL.js 90.00% <100.00%> (-10.00%) ⬇️
client-src/utils/reloadApp.js 82.60% <100.00%> (-4.35%) ⬇️
lib/utils/DevServerPlugin.js 98.61% <100.00%> (+0.99%) ⬆️
lib/Server.js 94.42% <0.00%> (+0.32%) ⬆️
lib/servers/WebsocketServer.js 92.10% <0.00%> (+2.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b559738...992be8e. Read the comment docs.

@alexander-akait alexander-akait merged commit 22f18eb into master Jun 28, 2021
@alexander-akait alexander-akait deleted the fix-allow-to-use-80-port branch June 28, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant