Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not start connent to web socket server when server socket doesn't start #3873

Closed
alexander-akait opened this issue Sep 23, 2021 · 1 comment · Fixed by #3879
Closed

do not start connent to web socket server when server socket doesn't start #3873

alexander-akait opened this issue Sep 23, 2021 · 1 comment · Fixed by #3879

Comments

@alexander-akait
Copy link
Member

webSocketServer: false should be enough

Agreed.
But without client: false, I noticed that the served js still trying to connect to ws server, but returning 404 as server was disabled by webSocketServer: false. This may bother someone with OCD. lol

image

Originally posted by @fevernova90 in #1430 (comment)
@alexander-akait alexander-akait mentioned this issue Sep 24, 2021
Merged
6 tasks
@fevernova90
Copy link

Awesome! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: avoid connection when web socket server is not running webpack/webpack-dev-server
2 participants
@alexander-akait @fevernova90