Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardcoded sockjs iframe url #4348

Closed
Zekfad opened this issue Mar 19, 2022 · 5 comments · Fixed by #4586
Closed

hardcoded sockjs iframe url #4348

Zekfad opened this issue Mar 19, 2022 · 5 comments · Fixed by #4586

Comments

@Zekfad
Copy link

Zekfad commented Mar 19, 2022

Why this is hardcoded?

sockjs_url: "/__webpack_dev_server__/sockjs.bundle.js",

In our project this is failing because we have a different from __webpack_dev_server__ path.

@snitin315
Copy link
Member

Hmm, we can add an option for this.

@Zekfad
Copy link
Author

Zekfad commented Mar 20, 2022

Hmm, we can add an option for this.

That would be nice!

@alexander-akait
Copy link
Member

Why you need to change it? It is potential security problem

@Zekfad
Copy link
Author

Zekfad commented Mar 20, 2022

Because we have only a few restricted paths lead to a webpack server backend in development.
Also its a security problem not to change it, as it can be a really easy for scanners and so on.

Also I expected that this URL is supposed to be the same as devServer.webSocketServer.options.path setting.

@alexander-akait
Copy link
Member

Okay PR welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants