Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pragma style with eval-source-map devtool does not follow documentation #120

Closed
pksjce opened this issue Sep 7, 2016 · 4 comments
Closed
Labels

Comments

@pksjce
Copy link

pksjce commented Sep 7, 2016

From @keirlawson on January 8, 2016 10:14

Documentation states that the pragma style for source maps defaults to #, yet I'm finding with Webpack 1.12.10 with devtool set to eval-source-map, the pragma style seems to default to @, causing Firefox to complain:

Using //@ to indicate sourceMappingURL pragmas is deprecated. Use //# instead

Copied from original issue: webpack/webpack#1865

@pksjce
Copy link
Author

pksjce commented Sep 7, 2016

From @sokra on January 8, 2016 16:23

Documentation states that the pragma style for source maps defaults to #

Propably already updated for webpack 2...

You can specify: devtool: "#eval-source-map"

@pksjce
Copy link
Author

pksjce commented Sep 7, 2016

From @cageygee3 on March 30, 2016 19:5

I'm also seeing this. Adding a hash to the front of the devtool setting string does fix the problem, but indicates that the documentation is wrong about the default.

@pksjce
Copy link
Author

pksjce commented Sep 7, 2016

From @irnc on May 4, 2016 14:47

I updated documentation to clarify defaults for each major version. Change could be seen at https://github.com/webpack/docs/wiki/configuration/_compare/207d9e5b0e8d69b1bdd15675e1fb5a40ab29457c...3c4be00157ddad325e3aa52e2d99a01accfcb6b2

@sokra Could you please review and publish that change?

@SpaceK33z
Copy link
Member

Tested this, and webpack v2 uses # as default, which is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants