Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins - Document name Option in i18n-plugin #1330

Closed
webpack-bot opened this issue Jun 23, 2017 · 5 comments
Closed

Plugins - Document name Option in i18n-plugin #1330

webpack-bot opened this issue Jun 23, 2017 · 5 comments
Assignees
Labels

Comments

@webpack-bot
Copy link

Do you want to request a feature or report a bug?
Documentation bug at https://github.com/webpack/webpack/tree/master/examples/i18n

What is the current behavior?
The example shows a 'name' key which is not in the webpack documentation (and I assume isn't actually a webpack configuration parameter).

If the current behavior is a bug, please provide the steps to reproduce.
N/A

What is the expected behavior?
The example should be minimal, and only show what's required for a proof of concept.

Specifically, I thought I needed a "name" in my config for some reason, but I don't!

If this is a feature request, what is motivation or use case for changing the behavior?
N/A
Please mention other relevant information such as the browser version, Node.js version, webpack version and Operating System.
N/A


This issue was moved from webpack/webpack#5144 by @sokra. Orginal issue was by @hovissimo.

Document name option.

@skipjack skipjack changed the title i18n-webpack-example has a confusing webpack config key General - Document name Option in i18n-webpack-example Jun 23, 2017
@skipjack
Copy link
Collaborator

@sokra the linked example is actually in the main repository... so should this be moved back or is there some corresponding docs in this repo? Or do we need to add an entirely new page for this plugin?

@skipjack
Copy link
Collaborator

skipjack commented Jun 23, 2017

Also maybe starting to remove some of the /examples from the main repo would be a good idea. At least the ones that overlap with the documentation here. I think it confuses things to have multiple sources of truth.

@skipjack skipjack changed the title General - Document name Option in i18n-webpack-example Plugins - Document name Option in i18n-webpack-example Jun 23, 2017
@skipjack skipjack changed the title Plugins - Document name Option in i18n-webpack-example Plugins - Document name Option in i18n-plugin Jun 23, 2017
@hovissimo
Copy link

Having the plugin example in the main repo is definitely confusing.

@skipjack skipjack self-assigned this Jun 24, 2017
@skipjack
Copy link
Collaborator

Ah so it seems we do have a page here. I'll take a stab at cleaning this up and documenting the missing key.

@skipjack
Copy link
Collaborator

Ah I didn't realize this plugin's documentation is actually pulled in dynamically from the plugin's repository. Moving the issue to webpack-contrib/i18n-webpack-plugin#54 and will try to help push it forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants