You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
From what I can tell, watchOptions.ignored still causes watchpack to watch all files and directories (including node_modules etc), only to potentially have the IgnoringWatchFileSystem ignore the results of the change. Meanwhile, using watchOptions.ignored will simply ignore the file from watching altogether, which seems like a "lower level" way to accomplish the same thing.
In our project, using WebpackIgnorePlugin causes watchpack's fileWatchers map to have 200k entries, while using watchOptions.ignored with the same regex's (or glob equivalents) drops that to 30k - we have a lot of node_modules!
From what I can tell, there may be a difference due to the the watchpack only watching directories and/or merging watchers, which may cause change events emitting from files that intuitively seem "ignored".
The difference between these two settings feels fairly nuanced, but I havent been able to find much about what the specific differences there are. Can they be merged? If not, does it make sense to pass the same list of ignores to both?
On that same note, can we allow regex's in watchOptions.ignored? webpack/watchpack#197
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Hi --
From what I can tell,
watchOptions.ignored
still causes watchpack to watch all files and directories (includingnode_modules
etc), only to potentially have theIgnoringWatchFileSystem
ignore the results of the change. Meanwhile, usingwatchOptions.ignored
will simply ignore the file from watching altogether, which seems like a "lower level" way to accomplish the same thing.In our project, using
WebpackIgnorePlugin
causes watchpack's fileWatchers map to have 200k entries, while usingwatchOptions.ignored
with the same regex's (or glob equivalents) drops that to 30k - we have a lot ofnode_modules
!From what I can tell, there may be a difference due to the the watchpack only watching directories and/or merging watchers, which may cause change events emitting from files that intuitively seem "ignored".
The difference between these two settings feels fairly nuanced, but I havent been able to find much about what the specific differences there are. Can they be merged? If not, does it make sense to pass the same list of ignores to both?
On that same note, can we allow regex's in
watchOptions.ignored
? webpack/watchpack#197Beta Was this translation helpful? Give feedback.
All reactions