Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean-webpack-plugin should be an internal webpack plugin #12221

Closed
yoavain opened this issue Dec 17, 2020 · 3 comments
Closed

clean-webpack-plugin should be an internal webpack plugin #12221

yoavain opened this issue Dec 17, 2020 · 3 comments

Comments

@yoavain
Copy link

yoavain commented Dec 17, 2020

Feature request

What is the expected behavior?

  1. clean-webpack-plugin should work with TypeScript configuration
  2. clean-webpack-plugin should be maintained since it is recommended in the documentation:
    https://webpack.js.org/guides/output-management/#cleaning-up-the-dist-folder

What is motivation or use case for adding/changing the behavior?

  1. Last version of clean-webpack-plugin was published in May 2019
  2. There's a typing bug in that repo from October 2019 that is not addressed and prevent using TypeScript configuration:
    The typings issue while upgrade to webpack@5.1.3 johnagan/clean-webpack-plugin#188

How should this be implemented in your opinion?
Repo should be forked and published as an internal webpack plugin.
Alternatively, recommend a different plugin that can work with TypeScript

Are you willing to work on this yourself?
maybe

@sokra
Copy link
Member

sokra commented Dec 17, 2020

Yes, we are actually planning to make this an integrated feature with output.clean: true, but we are not there yet.

see #11561

@alexander-akait
Copy link
Member

Improved #11561

@alexander-akait
Copy link
Member

We have dry and keep options, also we remove only webpack assets for perf reasons, so we strongly recommend to use copy-webpack-plugin to copy assets, so I think we can close original issue, if you have problems or idea to improvements, please open the new issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants