Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpack --watch does not check if stdin was closed #1308

Closed
matthewlehner opened this issue Jul 29, 2015 · 3 comments
Closed

webpack --watch does not check if stdin was closed #1308

matthewlehner opened this issue Jul 29, 2015 · 3 comments

Comments

@matthewlehner
Copy link
Contributor

This is basically a clone of brunch/brunch#920, but for context:

I would like to automatically run webpack --watch as part of my application but, when it shuts down, the webpack process persists and continues running. I have observed that my application does close STDIN, however, webpack --watch is not checking if STDIN was closed or not. These two lines solve the issue:

process.stdin.on('end', function() { process.exit(0) });
process.stdin.resume();

See matthewlehner/webpack@879ab0b for the fix, implemented.

I can send a pull request for this, but am wondering if this should always run this or if it should be it opt-in.

@sokra
Copy link
Member

sokra commented Jul 29, 2015

No sure either. Sounds like a valid PR.

@bebraw
Copy link
Contributor

bebraw commented Aug 29, 2016

Is this relevant still? I can see a related PR was merged.

@matthewlehner
Copy link
Contributor Author

Ah, this was closed with #1311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants