New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webpack --watch does not check if stdin was closed #1308
Comments
No sure either. Sounds like a valid PR. |
Is this relevant still? I can see a related PR was merged. |
Ah, this was closed with #1311 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is basically a clone of brunch/brunch#920, but for context:
I would like to automatically run
webpack --watch
as part of my application but, when it shuts down, the webpack process persists and continues running. I have observed that my application does close STDIN, however,webpack --watch
is not checking if STDIN was closed or not. These two lines solve the issue:See matthewlehner/webpack@879ab0b for the fix, implemented.
I can send a pull request for this, but am wondering if this should always run this or if it should be it opt-in.
The text was updated successfully, but these errors were encountered: