Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack 5 dealing with globals differently - Not found in changelog #17995

Closed
michael-whelan opened this issue Jan 23, 2024 · 0 comments
Closed

Comments

@michael-whelan
Copy link

Bug report

version: Webpack 5.89

What is the current behavior?
When clicking on some elements of the site we redirect to partner sites (in a new tab).
The decision to redirect to a partner, to another area of the site or to block with a sign up request is made in a third party service.
As a result when the response is returned to allow the redirect we use globals.window.open(leadHref, "_blank") to open the new tab.
Since the upgrade to webpack5 we noticed that the globals.window.open(leadHref, "_blank") was being blocked on ios mobile with the note popup blocked.

If any changes have happened to the way webpack deals with the window.open in version 5 I could not find them noted in the changelog.

If the current behavior is a bug, please provide the steps to reproduce.
Visit site on ios mobile
Click store element on feed.
Witness that the new tab did not open.
Click a second time -> tab opens on partner site as expected.

What is the expected behavior?
Clicking on an element and after the decision to open a partner site we should open a tab with the partner site.

Other relevant information:
webpack version: 5.89
Node.js version: >=18.x
Operating System: ios mobile
Additional tools:

@webpack webpack locked and limited conversation to collaborators Jan 23, 2024
@alexander-akait alexander-akait converted this issue into discussion #17996 Jan 23, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant