Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpacking ded/klass #32

Closed
rdrey opened this issue Nov 4, 2012 · 4 comments · May be fixed by tjenkinson/webpack#5
Closed

webpacking ded/klass #32

rdrey opened this issue Nov 4, 2012 · 4 comments · May be fixed by tjenkinson/webpack#5

Comments

@rdrey
Copy link
Contributor

rdrey commented Nov 4, 2012

Hey,

I'm trying to pack https://github.com/ded/klass and webpack isn't impressed with it:

> webpack node_modules/klass/klass.js klass.packed.js

Hash: 214a480310b53c1a2c79305e8fbc6cf7
Compile Time: 124ms
Chunks: 1
Modules: 1
Modules including duplicates: 1
Modules first chunk: 1
main   klass.packed.js:      893 chars/bytes

 <id>    <size>  <filename>
klass.packed.js
    0            ./~/klass/klass.js
ERROR: Entry module failed!
 Error: File "/Users/rainerdreyer/Workspace/PipeDream/node_modules/klass/klass.js" parsing failed: TypeError: Cannot call method 'push' of undefined
 @ ./klass.js

But there is no call to push in the klass source code as far as I can see. Could you check why webpack can't handle this? Unfortunately most of my code uses inheritance with klass, so the packaging of everything fails.

Thanks!

sokra added a commit that referenced this issue Nov 5, 2012
sokra added a commit that referenced this issue Nov 5, 2012
@sokra
Copy link
Member

sokra commented Nov 5, 2012

yeah, found 3 bugs ;)

Hope npm is not rate limited... ;)

Thanks

@sokra sokra closed this as completed Nov 5, 2012
@sokra
Copy link
Member

sokra commented Nov 5, 2012

> webpack node_modules/klass/klass.js klass.packed.js

Hash: d98a151c9ba0466da6c548e09e263a23
Compile Time: 56ms
Chunks: 1
Modules: 4
Modules including duplicates: 4
Modules first chunk: 4
main   klass.packed.js:     4473 chars/bytes

 <id>    <size>  <filename>
klass.packed.js
    0      2251  .\~\klass\klass.js
    1       533  (webpack)\buildin\__webpack_amd_define.js
    2       428  (webpack)\buildin\__webpack_amd_require.js
    3        24  (webpack)\buildin\__webpack_options_amd.loader.js!(webpack)\buildin\__webpack_options_amd.loader.js

@rdrey
Copy link
Contributor Author

rdrey commented Nov 5, 2012

Sweet! :) Thanks for the quick fixes!

@sokra
Copy link
Member

sokra commented Nov 5, 2012

Thanks for the report 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants