Include module file and context dependencies in ConcatenatedModule #5137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As ModuleConcatenationPlugin removes the concatenated modules from a compilation, the file and context dependencies of those modules needs to be stored in the ConcatenatedModule for webpack to be able to watch those paths.
mzgoddard
force-pushed
the
concatenated-file-dependencies
branch
from
30c95fd
to
9ea40f0
Compare
|
Happy to add tests. Just need direction on that. Not sure where to add an appropriate test. |
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
|
You can add a watchTest -> |
ModuleConcatenationPlugin creates a ConcatenatedModule from harmony modules. It must be rebuilt when those modules change.
|
Test added. Let me know if you want any changes. |
sokra
approved these changes
Jul 1, 2017
|
Thanks |
This was referenced Jul 7, 2017
This was referenced Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix #5132
Did you add tests for your changes?
Yes
If relevant, link to documentation update:
N/A
Summary
#5132
As ModuleConcatenationPlugin removes the concatenated modules from a
compilation, the file and context dependencies of those modules needs
to be stored in the ConcatenatedModule for webpack to be able to watch
those paths.
Does this PR introduce a breaking change?
No
Other information