RFC: Ignore context in resolve caching when resolve or resolveLoader plugins are provided. #5178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikesherov
changed the title
sokra
requested changes
Jul 1, 2017
package.json
Outdated
| @@ -9,7 +9,7 @@ | |||
| "ajv": "^5.1.5", | |||
| "ajv-keywords": "^2.0.0", | |||
| "async": "^2.1.2", | |||
| "enhanced-resolve": "^3.0.0", | |||
| "enhanced-resolve": "mikesherov/enhanced-resolve#b03799b6f06f82423e0a5c57fcc196b8eaeb8c07", | |||
sokra
requested changes
Jul 1, 2017
TheLarkInn
approved these changes
Jul 1, 2017
|
@sokra Thanks for your update. I labeled the Pull Request so reviewers will review it again. @TheLarkInn Please review the new changes. |
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-approved
PR: reviewed-changes-requested
labels
sokra
approved these changes
Jul 1, 2017
webpack-bot
added
PR: reviewed-approved
PR: CI-ok
and removed
PR: review-outdated
PR: CI-not-ok
labels
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
|
Thanks |
|
@sokra should we expect new release (with this fix included) in next week or so? I am just trying to understand what is better way for us: wait a bit or stick to particular changeset Thanks in advance |
This was referenced Jul 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4863
The CI builds will fail because they're pointing to my fork of enhanced-resolve, so this is just an RFC showing how we'd use webpack/enhanced-resolve#92 to address the issue at hand.
In the future, we can even make resolve or resolveLoader plugins specify whether they need
contextand we can make thecacheWithContextcheck smarter.