Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed statement 'var' to 'const' #5210

Merged
merged 1 commit into from Jul 6, 2017
Merged

Conversation

ematipico
Copy link
Contributor

What kind of change does this PR introduce?
Refactoring

Did you add tests for your changes?
No

If relevant, link to documentation update:

Summary

Just a quick refactoring for ES6 whole refactor

Does this PR introduce a breaking change?
No

Other information

@jsf-clabot
Copy link

jsf-clabot commented Jul 4, 2017

CLA assistant check
All committers have signed the CLA.

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@webpack-bot
Copy link
Contributor

Hi @ematipico.

Just a little hint from a friendly bot about the best practice when submitting pull requests:

Don't submit pull request from your own master branch. It's recommended to create a feature branch for the PR.

You don't have to change it for this PR, just make sure to follow this hint the next time you submit a PR.

@sokra sokra merged commit e365b2e into webpack:master Jul 6, 2017
@sokra
Copy link
Member

sokra commented Jul 6, 2017

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants