Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

knip@2.0.0 fails in Sveltekit (ERR_PACKAGE_PATH_NOT_EXPORTED) #99

Closed
vojtechsimetka opened this issue Mar 23, 2023 · 2 comments
Closed

Comments

@vojtechsimetka
Copy link
Contributor

vojtechsimetka commented Mar 23, 2023

Description

I tried to run knip in SvelteKit (even completely new project) but it fails.

Minimal example

https://github.com/vojtechsimetka/knip-demo

How to reproduce

npm create svelte@latest knip-demo
cd knip-demo
npm i
npx knip

System

 System:
    OS: macOS 13.2.1
    CPU: (8) arm64 Apple M1
    Memory: 88.92 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 18.15.0 - ~/.nvm/versions/node/v18.15.0/bin/node
    npm: 9.5.0 - ~/.nvm/versions/node/v18.15.0/bin/npm
  Knip version:
    2.0.0

Error

> knip-demo@0.0.1 knip
> knip

Analyzing workspace (.)...
file:///Users/redacted/knip-demo/node_modules/knip/dist/util/loader.js:28
        throw new LoaderError(`Error loading ${filePath}`, { cause: error });
              ^

LoaderError: Error loading /Users/redacted/knip-demo/vite.config.ts
    at load (file:///Users/redacted/knip-demo/node_modules/knip/dist/util/loader.js:28:15)
    at Module.findVitestDependencies (file:///Users/redacted/knip-demo/node_modules/knip/dist/plugins/vitest/index.js:10:26)
    at WorkspaceWorker.findDependenciesByPlugins (file:///Users/redacted/knip-demo/node_modules/knip/dist/workspace-worker.js:217:59)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async WorkspaceWorker.findAllDependencies (file:///Users/redacted/knip-demo/node_modules/knip/dist/workspace-worker.js:236:9)
    at async main (file:///Users/redacted/knip-demo/node_modules/knip/dist/index.js:119:30)
    at async run (file:///Users/redacted/knip-demo/node_modules/knip/dist/cli.js:26:46)
    at async file:///Users/redacted/knip-demo/node_modules/knip/dist/cli.js:57:1 {
  [cause]: Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './vite' is not defined by "exports" in /Users/redacted/knip-demo/node_modules/@sveltejs/kit/package.json
      at new NodeError (node:internal/errors:387:5)
      at throwExportsNotFound (node:internal/modules/esm/resolve:365:9)
      at packageExportsResolve (node:internal/modules/esm/resolve:589:7)
      at resolveExports (node:internal/modules/cjs/loader:554:36)
      at Function.Module._findPath (node:internal/modules/cjs/loader:594:31)
      at Function.Module._resolveFilename (node:internal/modules/cjs/loader:1007:27)
      at Function.resolve (node:internal/modules/cjs/helpers:114:19)
      at _resolve (/Users/redacted/knip-demo/node_modules/jiti/dist/jiti.js:1:241025)
      at jiti (/Users/redacted/knip-demo/node_modules/jiti/dist/jiti.js:1:243309)
      at /Users/redacted/knip-demo/vite.config.ts:1:175 {
    code: 'ERR_PACKAGE_PATH_NOT_EXPORTED'
  }
}

BTW I absolutely love knip!!! Thank you very much for creating it and I'd happily contribute!

@vojtechsimetka vojtechsimetka changed the title Knip fails in Sveltekit (ERR_PACKAGE_PATH_NOT_EXPORTED) knip@2.0.0 fails in Sveltekit (ERR_PACKAGE_PATH_NOT_EXPORTED) Mar 23, 2023
@webpro
Copy link
Collaborator

webpro commented Mar 23, 2023

Thanks for the detailed report, Vojtech! I think I see the issue and will release a patch soon.

@webpro webpro closed this as completed in e31ab3a Mar 23, 2023
@webpro
Copy link
Collaborator

webpro commented Mar 23, 2023

Should be fixed in v2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants