New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define and implement a strategy for "obscure" things like husky + lint-staged #31
Comments
Done in 73445e8 (v1.5.0) |
Hmm still seeing |
According to the husky docs: {
"scripts": {
"prepare": "husky install"
}
} Or in Just saying, the job of plugins is mostly to find dependencies of, in this case, husky, which it finds by scanning the Git hooks themselves (which contains the |
The
husky
dependency demands to runhusky install
which addshooksPath = .husky
to.git/config
. Then, for example,lint-staged
could be executed from an executable script such as.husky/pre-commit
.This means packages like this require another way of finding out whether they're actually used or not:
husky
: look forgit config core.hooksPath
and see if result (.husky
) is existing directory?lint-staged
: based on the tool used (not necessarily husky!), find it's usage in such a script or config fileNot sure if this is the way to go and/or if it would be enough. And it's just an example, there are more (popular) tools out there that do things differently (not judging). I'm inclined to think it's feasible for Knip to add another type of plugin, or extend the existing plugin system for such use cases.
Just saying, packages can always be added to the
ignoreDependencies
list to get rid of such false positives.The text was updated successfully, but these errors were encountered: