Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in v3.3.5 - The system cannot find the path specified. #377

Closed
Zamiell opened this issue Dec 1, 2023 · 5 comments
Closed

Regression in v3.3.5 - The system cannot find the path specified. #377

Zamiell opened this issue Dec 1, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@Zamiell
Copy link
Contributor

Zamiell commented Dec 1, 2023

Steps to reproduce:

git clone git@github.com:IsaacScript/isaacscript.git
cd isaacscript
git checkout de7eb6af04b57afc3236e4132e593956ca52fe45
yarn install
npx knip --exclude dependencies

After doing this, you should notice that the output is:

The system cannot find the path specified.
The system cannot find the path specified.
  • Next, update the "package.json" file and change "knip": "^3.3.5", to "knip": "3.3.4",
  • Then, run: yarn install
  • Then, run npx knip --exclude dependencies

Notice that the error messages do not appear. Thus, this is a regression in v3.3.5.

@Zamiell Zamiell added the bug Something isn't working label Dec 1, 2023
@Zamiell Zamiell changed the title Regression in 3.3.5 - The system cannot find the path specified. Regression in v3.3.5 - The system cannot find the path specified. Dec 1, 2023
@webpro
Copy link
Collaborator

webpro commented Dec 1, 2023

No I don't see that error, can't reproduce. The messages do not appear.

@Zamiell
Copy link
Contributor Author

Zamiell commented Dec 1, 2023

I'm using Windows 10. Maybe this is an OS-specific regression?
I tested in both Windows Command Prompt and Git Bash, and the errors appear in both of them.

@webpro webpro closed this as completed in b854409 Dec 2, 2023
@webpro
Copy link
Collaborator

webpro commented Dec 2, 2023

🚀 This issue has been resolved in v3.4.0. See Release 3.4.0 for release notes.

@webpro
Copy link
Collaborator

webpro commented Dec 2, 2023

Looking at the commits that went into v3.3.5 I think I found the issue and it should be fixed now. Thanks for the report and bearing with me :)

@Zamiell
Copy link
Contributor Author

Zamiell commented Dec 2, 2023

No problem, appreciate the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants