Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for more script files #396

Closed
what1s1ove opened this issue Dec 17, 2023 · 2 comments
Closed

Add support for more script files #396

what1s1ove opened this issue Dec 17, 2023 · 2 comments
Labels
discussion Discussion

Comments

@what1s1ove
Copy link
Contributor

Hey guys!

Before using your package, I used a Makefile as a file to store all my application scripts (not the scripts section in package.json). There are many reasons for this (comment support, variables, working with all platforms (Deno, Bun, etc.), and so on). I migrated the scripts to package.json along with your package since I have fairly small projects. However, as a future plan, you might want to consider expanding support for script files.

@what1s1ove what1s1ove added the discussion Discussion label Dec 17, 2023
@what1s1ove what1s1ove changed the title Add support for more script files. Add support for more script files Dec 17, 2023
@webpro
Copy link
Collaborator

webpro commented Dec 18, 2023

Knip has support for bash/script files, plugins like husky, lefthook and lint-staged use this.

Depending on the generic usefulness we could think of a new plugin? I have no idea if parsing a Makefile is feasible (for bash-parser)?

If you're interested, you can search for "bash parser" and "tree sitter" in this repo for some drama around the topic :)

@webpro
Copy link
Collaborator

webpro commented Mar 24, 2024

Going to close this one, feel free to request plugins in #483

@webpro webpro closed this as completed Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Discussion
Projects
None yet
Development

No branches or pull requests

2 participants