Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positives on Unresolved paths (repro in issue) #689

Closed
AlemTuzlak opened this issue Jun 21, 2024 · 3 comments
Closed

False positives on Unresolved paths (repro in issue) #689

AlemTuzlak opened this issue Jun 21, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@AlemTuzlak
Copy link

Description

While implementing Knip in our monorepo with Turbo we used the approach of defining tsconfig.json files as provided in the repro, the config is resolved correctly and loaded into the apps but knip complains that the imports don't exist, I believe the reason for this is that knip checks the current folder (core) instead of the root from where the tsconfig.remix.json extended the config from.

Expected behavior

  • Knip found no issues

Actual behavior

Knip found Unresolved imports

https://stackblitz.com/edit/vitejs-vite-keewbt?file=apps%2Fcore%2Ftsconfig.json

@AlemTuzlak AlemTuzlak added the bug Something isn't working label Jun 21, 2024
@webpro
Copy link
Collaborator

webpro commented Jun 21, 2024

🚀 This issue has been resolved in v5.22.2. See Release 5.22.2 for release notes.

Using Knip in a commercial project? Please consider becoming a sponsor.

@webpro webpro closed this as completed in d1261c1 Jun 21, 2024
@webpro
Copy link
Collaborator

webpro commented Jun 21, 2024

Thanks for the bug report and repro Alem, should be fixed in v5.22.2!

@AlemTuzlak
Copy link
Author

@webpro It's fixed, you're a freaking saint!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants