You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for creating this NX Executor, I was looking after something to 'lint' my .ts files.
I have found an issue, thought. When the shell option in the spawn call is set to true (in the case of this executor, when it is running in Windows), if the folder where tsc is located has empty spaces on it (for example: C:\User\trystan2k\One Drive Files\my-project\node_modules\tsc), the spawn execution fails because it gets only the folder name until the first space (so it says something like "Cannot find folder C:\User\trystan2k\One").
After some researching, I found that we can work around this by setting the folder name between "" (but only when shell is true).
I will open a PR with this fix. Please let me know if it is ok or if you have any other suggestion.
Thank you !
The text was updated successfully, but these errors were encountered:
Hi @webpro,
Thanks for creating this NX Executor, I was looking after something to 'lint' my .ts files.
I have found an issue, thought. When the
shell
option in thespawn
call is set to true (in the case of this executor, when it is running in Windows), if the folder wheretsc
is located has empty spaces on it (for example: C:\User\trystan2k\One Drive Files\my-project\node_modules\tsc), the spawn execution fails because it gets only the folder name until the first space (so it says something like "Cannot find folder C:\User\trystan2k\One").After some researching, I found that we can work around this by setting the folder name between "" (but only when shell is true).
I will open a PR with this fix. Please let me know if it is ok or if you have any other suggestion.
Thank you !
The text was updated successfully, but these errors were encountered: