Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail when shell is true and folder has empty characters in its name #1

Closed
trystan2k opened this issue Oct 18, 2022 · 0 comments
Closed

Comments

@trystan2k
Copy link

Hi @webpro,

Thanks for creating this NX Executor, I was looking after something to 'lint' my .ts files.

I have found an issue, thought. When the shell option in the spawn call is set to true (in the case of this executor, when it is running in Windows), if the folder where tsc is located has empty spaces on it (for example: C:\User\trystan2k\One Drive Files\my-project\node_modules\tsc), the spawn execution fails because it gets only the folder name until the first space (so it says something like "Cannot find folder C:\User\trystan2k\One").

After some researching, I found that we can work around this by setting the folder name between "" (but only when shell is true).

I will open a PR with this fix. Please let me know if it is ok or if you have any other suggestion.

Thank you !

@trystan2k trystan2k closed this as not planned Won't fix, can't repro, duplicate, stale May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant