Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crawl config validation #88

Closed
1 of 2 tasks
SuaYoo opened this issue Jan 18, 2022 · 2 comments
Closed
1 of 2 tasks

Crawl config validation #88

SuaYoo opened this issue Jan 18, 2022 · 2 comments
Assignees
@ikreymer @SuaYoo
Labels
question Further information is requested, label should be removed once answered

Comments

@SuaYoo
Copy link
Collaborator

SuaYoo commented Jan 18, 2022 •
edited by ikreymer
Loading

  • Server-side validation for POST/PATCH
  • Client-side validation for both form and JSON editor
@ikreymer
Copy link
Member

ikreymer commented Feb 1, 2022

I believe there should already be server-side validation for the json config (as well as for all api endpoints).
Unknown fields are allowed for extensibility, but could make it more strict - actually they may be getting ignored.

The cron-style schedule is not being validated, however.

Were you thinking of additional validation here?

@Shrinks99 Shrinks99 added the question Further information is requested, label should be removed once answered label Aug 15, 2022
@ikreymer
Copy link
Member

The custom JSON editor has been removed, can close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ikreymer ikreymer

@SuaYoo SuaYoo

Labels
question Further information is requested, label should be removed once answered
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ikreymer @SuaYoo @Shrinks99